summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authormo khan <mo@mokhan.ca>2021-02-27 17:38:07 -0700
committermo khan <mo@mokhan.ca>2021-02-27 17:38:07 -0700
commit3949feb22fdda9986dfb2fafd2b95b290f528cb3 (patch)
treebe13c7ea1fac0785f795a7eb4983a2f527423904 /lib
parent145b96c6284e9f183d81c52cae5db2dd22bb8d64 (diff)
move checklist to header
Diffstat (limited to 'lib')
-rw-r--r--lib/jive/templates/pull_request_template.md30
1 files changed, 15 insertions, 15 deletions
diff --git a/lib/jive/templates/pull_request_template.md b/lib/jive/templates/pull_request_template.md
index cac4b66..14288ee 100644
--- a/lib/jive/templates/pull_request_template.md
+++ b/lib/jive/templates/pull_request_template.md
@@ -1,6 +1,15 @@
-# Pull Request Template
+---
+title: "Pull Request Template"
+checklist:
+- [ ] Clear description explaining the relevancy of the contribution.
+- [ ] Unit, integration, and system tests.
+- [ ] Regression and bugs are covered with tests.
+- [ ] [Performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
+- [ ] [Secure coding guidelines](https://docs.gitlab.com/ee/development/secure_coding_guidelines.html)
+- [ ] Documentation Updated
+---
-## Why is this needed?
+# Why is this needed?
## What does this do?
@@ -16,11 +25,11 @@ Fixes # (issue)
Before:
-![before]()
+![Before][before]
After:
-![after]()
+![After][after]
## Type of change
@@ -38,14 +47,5 @@ After:
- [ ] Step 1
- [ ] Step 2
-## Checklist
-
-- [ ] Clear description explaining the relevancy of the contribution.
-- [ ] Unit, integration, and system tests.
-- [ ] Regression and bugs are covered with tests.
-- [ ] [Performance guidelines][performance]
-- [ ] [Secure coding guidelines][secure]
-- [ ] Documentation Updated
-
-[performance]: https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html
-[secure]: https://docs.gitlab.com/ee/development/secure_coding_guidelines.html
+[after]: https://user-images.githubusercontent.com/x/y.png
+[before]: https://user-images.githubusercontent.com/x/y.png