diff options
| author | mo <mo.khan@gmail.com> | 2019-07-13 16:02:19 -0600 |
|---|---|---|
| committer | mo <mo.khan@gmail.com> | 2019-07-13 16:02:19 -0600 |
| commit | f434c97421d82e93f20b948d3f504edf59c8c93a (patch) | |
| tree | 3397352bc0132da34cf33698f0745b7e1edbc8e5 | |
| parent | 6d8f6b80e9bf6670f73e9ce6e9757cf0a38580be (diff) | |
validate day underflow
| -rw-r--r-- | src/Q6/WeekDay.java | 2 | ||||
| -rw-r--r-- | src/Q6/WeekDayTest.java | 12 |
2 files changed, 12 insertions, 2 deletions
diff --git a/src/Q6/WeekDay.java b/src/Q6/WeekDay.java index 31d90b4..e7ccc11 100644 --- a/src/Q6/WeekDay.java +++ b/src/Q6/WeekDay.java @@ -34,7 +34,7 @@ public class WeekDay { } private void ensureValidDate(int year, int month, int day) { - if (day > MONTHS[month - 1]) throw new IllegalArgumentException(); + if (day < 1 || day > MONTHS[month - 1]) throw new IllegalArgumentException(); } public static void main(String[] args) { diff --git a/src/Q6/WeekDayTest.java b/src/Q6/WeekDayTest.java index 281e39e..203d08f 100644 --- a/src/Q6/WeekDayTest.java +++ b/src/Q6/WeekDayTest.java @@ -64,7 +64,7 @@ public class WeekDayTest extends TestCase { assertEquals("Sunday", subject.getWeekDay(31, 1, 2100)); } - public void test_getWeekDay_invalid_day() { + public void test_getWeekDay_day_too_large() { boolean raised = false; try { subject.getWeekDay(32, 1, 2100); @@ -73,4 +73,14 @@ public class WeekDayTest extends TestCase { } assertTrue(raised); } + + public void test_getWeekDay_day_too_small() { + boolean raised = false; + try { + subject.getWeekDay(0, 1, 2100); + } catch (IllegalArgumentException error) { + raised = true; + } + assertTrue(raised); + } } |
