diff options
Diffstat (limited to 'app/middleware/require_permission_test.go')
| -rw-r--r-- | app/middleware/require_permission_test.go | 29 |
1 files changed, 19 insertions, 10 deletions
diff --git a/app/middleware/require_permission_test.go b/app/middleware/require_permission_test.go index 34a04a7..df21b5a 100644 --- a/app/middleware/require_permission_test.go +++ b/app/middleware/require_permission_test.go @@ -5,16 +5,17 @@ import ( "net/http" "testing" + v1 "github.com/authzed/authzed-go/proto/authzed/api/v1" "github.com/stretchr/testify/require" "github.com/xlgmokha/x/pkg/test" - "gitlab.com/gitlab-org/software-supply-chain-security/authorization/authzd.git/pkg/rpc" "gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/cfg" "gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/domain" + "google.golang.org/grpc" ) -type MockAbility func(context.Context, *rpc.AllowRequest) (*rpc.AllowReply, error) +type MockAbility func(context.Context, *v1.CheckPermissionRequest) (*v1.CheckPermissionResponse, error) -func (m MockAbility) Allowed(ctx context.Context, r *rpc.AllowRequest) (*rpc.AllowReply, error) { +func (m MockAbility) CheckPermission(ctx context.Context, r *v1.CheckPermissionRequest, opts ...grpc.CallOption) (*v1.CheckPermissionResponse, error) { return m(ctx, r) } @@ -26,12 +27,18 @@ func TestRequirePermission(t *testing.T) { t.Run("when the permission is granted", func(t *testing.T) { r, w := test.RequestResponse("GET", "/sparkles", test.WithContext(ctx)) - middleware := RequirePermission(permission, MockAbility(func(ctx context.Context, r *rpc.AllowRequest) (*rpc.AllowReply, error) { - require.Equal(t, "gid://sparkle/User/"+user.ID.String(), r.Subject) - require.Equal(t, permission.ToGID(), r.Permission) - require.Equal(t, "gid://sparkle/Sparkle/*", r.Resource) + middleware := RequirePermission(permission, MockAbility(func(ctx context.Context, r *v1.CheckPermissionRequest) (*v1.CheckPermissionResponse, error) { + require.Equal(t, "user", r.Subject.Object.ObjectType) + require.Equal(t, user.Username, r.Subject.Object.ObjectId) - return &rpc.AllowReply{Result: true}, nil + require.Equal(t, permission.String(), r.Permission) + + require.Equal(t, "sparkle", r.Resource.ObjectType) + require.Equal(t, "*", r.Resource.ObjectId) + + return &v1.CheckPermissionResponse{ + Permissionship: v1.CheckPermissionResponse_PERMISSIONSHIP_HAS_PERMISSION, + }, nil })) server := middleware(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusTeapot) @@ -44,8 +51,10 @@ func TestRequirePermission(t *testing.T) { t.Run("when the permission is denied", func(t *testing.T) { r, w := test.RequestResponse("GET", "/sparkles", test.WithContext(ctx)) - middleware := RequirePermission(permission, MockAbility(func(ctx context.Context, r *rpc.AllowRequest) (*rpc.AllowReply, error) { - return &rpc.AllowReply{Result: false}, nil + middleware := RequirePermission(permission, MockAbility(func(ctx context.Context, r *v1.CheckPermissionRequest) (*v1.CheckPermissionResponse, error) { + return &v1.CheckPermissionResponse{ + Permissionship: v1.CheckPermissionResponse_PERMISSIONSHIP_NO_PERMISSION, + }, nil })) server := middleware(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { require.Fail(t, "unexpected call to handler") |