refactor: remove usage of Each

2 files changed, 2 insertions, 17 deletions

diff --git a/pkg/db/repository.go b/pkg/db/repository.go
index aaa6e51..ef4b9fb 100644
--- a/pkg/db/repository.go
+++ b/pkg/db/repository.go
@@ -7,7 +7,6 @@ import (
 
 type Repository interface {
 	All() []*domain.Sparkle
-	Each(func(*domain.Sparkle))
 	Save(*domain.Sparkle) error
 }
 
@@ -25,12 +24,6 @@ func (r *inMemoryRepository) All() []*domain.Sparkle {
 	return r.sparkles
 }
 
-func (r *inMemoryRepository) Each(visitor func(item *domain.Sparkle)) {
-	for _, item := range r.All() {
-		visitor(item)
-	}
-}
-
 func (r *inMemoryRepository) Save(item *domain.Sparkle) error {
 	if err := item.Validate(); err != nil {
 		return err
diff --git a/pkg/db/repository_test.go b/pkg/db/repository_test.go
index 6d4ee24..57aee13 100644
--- a/pkg/db/repository_test.go
+++ b/pkg/db/repository_test.go
@@ -15,23 +15,15 @@ func TestRepository(t *testing.T) {
 		t.Run("an invalid Sparkle", func(t *testing.T) {
 			err := storage.Save(&domain.Sparkle{Reason: "because"})
 
-			counter := 0
-			storage.Each(func(item *domain.Sparkle) {
-				counter++
-			})
-
 			assert.NotNil(t, err)
-			assert.Equal(t, 0, counter)
+			assert.Equal(t, 0, len(storage.All()))
 		})
 
 		t.Run("a valid Sparkle", func(t *testing.T) {
 			sparkle := &domain.Sparkle{Sparklee: "@tanuki", Reason: "because"}
 			require.NoError(t, storage.Save(sparkle))
 
-			sparkles := []*domain.Sparkle{}
-			storage.Each(func(item *domain.Sparkle) {
-				sparkles = append(sparkles, item)
-			})
+			sparkles := storage.All()
 			assert.Equal(t, 1, len(sparkles))
 			assert.NotEmpty(t, sparkles[0].ID)
 			assert.Equal(t, "@tanuki", sparkles[0].Sparklee)