summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authormo khan <mo@mokhan.ca>2025-07-23 15:33:14 -0600
committermo khan <mo@mokhan.ca>2025-07-23 15:33:14 -0600
commit7963e072161907e81544dcdc2ff04a49c9359096 (patch)
tree54c8c34feda2cdeee46cdf662d18d89889a7d609 /app
parentf861b0df276d26ef8db1e27678f807d22dabd6e3 (diff)
refactor: remove create permission check
Diffstat (limited to 'app')
-rw-r--r--app/controllers/sparkles/controller.go2
-rw-r--r--app/controllers/sparkles/controller_test.go1
-rw-r--r--app/middleware/require_permission.go5
3 files changed, 6 insertions, 2 deletions
diff --git a/app/controllers/sparkles/controller.go b/app/controllers/sparkles/controller.go
index ef2ecd5..90767b2 100644
--- a/app/controllers/sparkles/controller.go
+++ b/app/controllers/sparkles/controller.go
@@ -30,7 +30,7 @@ func (c *Controller) MountTo(mux *http.ServeMux) {
mux.Handle("POST /sparkles", x.Middleware[http.Handler](
http.HandlerFunc(c.Create),
middleware.RequireUser(),
- middleware.RequirePermission("create", c.check),
+ // middleware.RequirePermission("create", c.check),
))
// This is a temporary endpoint to restore a backup
diff --git a/app/controllers/sparkles/controller_test.go b/app/controllers/sparkles/controller_test.go
index 64b4dc5..d2469a7 100644
--- a/app/controllers/sparkles/controller_test.go
+++ b/app/controllers/sparkles/controller_test.go
@@ -121,6 +121,7 @@ func TestSparkles(t *testing.T) {
})
t.Run("when the user is not authorized", func(t *testing.T) {
+ t.Skip()
mux := http.NewServeMux()
controller := New(repository, stub.Deny())
controller.MountTo(mux)
diff --git a/app/middleware/require_permission.go b/app/middleware/require_permission.go
index 441b334..399602f 100644
--- a/app/middleware/require_permission.go
+++ b/app/middleware/require_permission.go
@@ -15,7 +15,10 @@ func RequirePermission(permission domain.Permission, client authz.CheckPermissio
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
user := cfg.CurrentUser.From(r.Context())
- reply, err := client.CheckPermission(r.Context(), permission.RequestFor(user, &domain.Sparkle{ID: "*"}))
+ reply, err := client.CheckPermission(r.Context(), permission.RequestFor(
+ user,
+ &domain.Sparkle{ID: "*"},
+ ))
if err != nil {
pls.LogError(r.Context(), err)
w.WriteHeader(http.StatusForbidden)