feat: authorize requests to create sparkles

3 files changed, 2 insertions, 28 deletions

diff --git a/app/middleware/permission.go b/app/middleware/permission.go
deleted file mode 100644
index 36a7ea0..0000000
--- a/app/middleware/permission.go
+++ /dev/null
@@ -1,26 +0,0 @@
-package middleware
-
-import (
-	v1 "github.com/authzed/authzed-go/proto/authzed/api/v1"
-	"gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/domain"
-)
-
-type Permission string
-
-func (p Permission) ToGID() string {
-	return "gid://sparkle/Permission/" + p.String()
-}
-
-func (p Permission) RequestFor(user domain.Identifiable, resource domain.Identifiable) *v1.CheckPermissionRequest {
-	return &v1.CheckPermissionRequest{
-		Subject: &v1.SubjectReference{
-			Object: user.ToObjectReference(),
-		},
-		Permission: p.String(),
-		Resource:   resource.ToObjectReference(),
-	}
-}
-
-func (p Permission) String() string {
-	return string(p)
-}
diff --git a/app/middleware/require_permission.go b/app/middleware/require_permission.go
index cfcae0c..441b334 100644
--- a/app/middleware/require_permission.go
+++ b/app/middleware/require_permission.go
@@ -10,7 +10,7 @@ import (
 	"gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/pkg/pls"
 )
 
-func RequirePermission(permission Permission, client authz.PermissionService) func(http.Handler) http.Handler {
+func RequirePermission(permission domain.Permission, client authz.CheckPermissionService) func(http.Handler) http.Handler {
 	return func(next http.Handler) http.Handler {
 		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			user := cfg.CurrentUser.From(r.Context())
diff --git a/app/middleware/require_permission_test.go b/app/middleware/require_permission_test.go
index b11a33c..2023345 100644
--- a/app/middleware/require_permission_test.go
+++ b/app/middleware/require_permission_test.go
@@ -14,7 +14,7 @@ import (
 func TestRequirePermission(t *testing.T) {
 	user := &domain.User{ID: domain.ID("1")}
 	ctx := cfg.CurrentUser.With(t.Context(), user)
-	permission := Permission("read")
+	permission := domain.Permission("read")
 
 	t.Run("when the permission is granted", func(t *testing.T) {
 		r, w := test.RequestResponse("GET", "/sparkles", test.WithContext(ctx))