summaryrefslogtreecommitdiff
path: root/app/controllers
diff options
context:
space:
mode:
authormo khan <mo@mokhan.ca>2025-04-25 16:29:45 -0600
committermo khan <mo@mokhan.ca>2025-04-28 09:07:31 -0600
commit10acef83528c746abeb597490d516a55b5a0955e (patch)
tree16979017ec6579b24afc84fb2ac02301cc7edef3 /app/controllers
parent6f03359ac68865d31c26c4600d79c3e985f002b4 (diff)
fix: render 404 when not logged in
Diffstat (limited to 'app/controllers')
-rw-r--r--app/controllers/dashboard/controller.go2
-rw-r--r--app/controllers/dashboard/controller_test.go4
-rw-r--r--app/controllers/sessions/controller.go2
-rw-r--r--app/controllers/sparkles/controller.go2
4 files changed, 5 insertions, 5 deletions
diff --git a/app/controllers/dashboard/controller.go b/app/controllers/dashboard/controller.go
index ef5b18d..220871f 100644
--- a/app/controllers/dashboard/controller.go
+++ b/app/controllers/dashboard/controller.go
@@ -17,7 +17,7 @@ func New() *Controller {
}
func (c *Controller) MountTo(mux *http.ServeMux) {
- requireUser := middleware.RequireUser(http.StatusFound, "/")
+ requireUser := middleware.RequireUser()
mux.Handle("GET /dashboard", requireUser(http.HandlerFunc(c.Show)))
}
diff --git a/app/controllers/dashboard/controller_test.go b/app/controllers/dashboard/controller_test.go
index ced3fd5..629a03a 100644
--- a/app/controllers/dashboard/controller_test.go
+++ b/app/controllers/dashboard/controller_test.go
@@ -22,9 +22,7 @@ func TestController(t *testing.T) {
mux.ServeHTTP(w, r)
- assert.Equal(t, http.StatusFound, w.Code)
- location := w.HeaderMap.Get("Location")
- assert.Equal(t, "/", location)
+ assert.Equal(t, http.StatusNotFound, w.Code)
})
})
diff --git a/app/controllers/sessions/controller.go b/app/controllers/sessions/controller.go
index 08002a2..9a65ae3 100644
--- a/app/controllers/sessions/controller.go
+++ b/app/controllers/sessions/controller.go
@@ -136,5 +136,5 @@ func (c *Controller) Create(w http.ResponseWriter, r *http.Request) {
}
http.SetCookie(w, cookie.New("session", encoded, tokens.Expiry))
- http.Redirect(w, r, "/dashboard", http.StatusFound)
+ http.Redirect(w, r, "/", http.StatusFound)
}
diff --git a/app/controllers/sparkles/controller.go b/app/controllers/sparkles/controller.go
index 9c319b2..e0da8c4 100644
--- a/app/controllers/sparkles/controller.go
+++ b/app/controllers/sparkles/controller.go
@@ -7,8 +7,10 @@ import (
"github.com/xlgmokha/x/pkg/mapper"
"github.com/xlgmokha/x/pkg/serde"
"github.com/xlgmokha/x/pkg/x"
+ "gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/cfg"
"gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/domain"
"gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/middleware"
+ "gitlab.com/gitlab-org/software-supply-chain-security/authorization/sparkled/app/views"
)
type Controller struct {