summaryrefslogtreecommitdiff
path: root/bin
diff options
context:
space:
mode:
authormo khan <mo.khan@gmail.com>2020-03-03 09:34:53 -0700
committermo khan <mo.khan@gmail.com>2020-03-03 09:34:53 -0700
commit6b2bc3d9b021e610d61477318e916b6692375900 (patch)
tree097b8fdc8446c2d56b7f32cf2cd1bf45d2b88d2e /bin
parentb5773fb506fbf90acca2c2e95febceb96dac3a95 (diff)
Fix shellcheck warnings
Diffstat (limited to 'bin')
-rwxr-xr-xbin/docker-dotenv10
-rwxr-xr-xbin/docker-shell2
-rwxr-xr-xbin/lint3
-rwxr-xr-xbin/test-all2
4 files changed, 8 insertions, 9 deletions
diff --git a/bin/docker-dotenv b/bin/docker-dotenv
index ca025c0..fb40a99 100755
--- a/bin/docker-dotenv
+++ b/bin/docker-dotenv
@@ -16,18 +16,18 @@ touch $DOCKERFILE
echo "FROM $SOURCE_IMAGE" > $DOCKERFILE
echo "Reading... $DOTENV"
-cat $DOTENV
+cat "$DOTENV"
while IFS= read -r line; do
echo "ENV $line" >> $DOCKERFILE
-done < $DOTENV
+done < "$DOTENV"
echo "Pulling... $SOURCE_IMAGE"
-docker pull $SOURCE_IMAGE
+docker pull "$SOURCE_IMAGE"
echo "Building... $DOCKERFILE and tagging $TARGET_IMAGE"
cat $DOCKERFILE
-docker build -t $TARGET_IMAGE -f $DOCKERFILE .
+docker build -t "$TARGET_IMAGE" -f $DOCKERFILE .
echo "Verifying env..."
-docker run --entrypoint='' $TARGET_IMAGE env
+docker run --entrypoint='' "$TARGET_IMAGE" env
diff --git a/bin/docker-shell b/bin/docker-shell
index be0db98..107f6b1 100755
--- a/bin/docker-shell
+++ b/bin/docker-shell
@@ -6,4 +6,4 @@ cd "$(dirname "$0")/.."
IMAGE_NAME=${IMAGE_NAME:-$(basename "$PWD"):latest}
-docker run --rm -it --entrypoint='' $1 "$IMAGE_NAME" /bin/bash -l
+docker run --rm -it --entrypoint='' "$1" "$IMAGE_NAME" /bin/bash -l
diff --git a/bin/lint b/bin/lint
index faf1cd4..e663b57 100755
--- a/bin/lint
+++ b/bin/lint
@@ -1,7 +1,6 @@
#!/bin/sh
shellcheck bin/*
-shellcheck config/*.sh
shellcheck config/.bashrc
shellcheck config/.profile
-# shellcheck run.sh
+shellcheck config/*.sh
diff --git a/bin/test-all b/bin/test-all
index 643eef5..be92121 100755
--- a/bin/test-all
+++ b/bin/test-all
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
set -e