summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormo khan <mo.khan@gmail.com>2020-09-16 15:56:11 -0600
committermo khan <mo.khan@gmail.com>2020-09-16 15:56:11 -0600
commit742c9f9c66d30e1471b5382ba0c9ee3967116efa (patch)
treef533eacdfea6397d1d5422ff9803af7525456a21
parentbbd64b04d484792307ed58f847d86df5bcbe7440 (diff)
chore: specify `scanner` for each test
-rw-r--r--spec/gemnasium_maven_spec.rb3
-rw-r--r--spec/spotbugs_spec.rb2
-rw-r--r--spec/support/scanner_context.rb5
3 files changed, 6 insertions, 4 deletions
diff --git a/spec/gemnasium_maven_spec.rb b/spec/gemnasium_maven_spec.rb
index 2f61a77..16511ec 100644
--- a/spec/gemnasium_maven_spec.rb
+++ b/spec/gemnasium_maven_spec.rb
@@ -1,9 +1,10 @@
require 'openssl'
RSpec.describe 'gemnasium-maven' do
+ let(:scanner) { self.class.description }
+
['8', '13', '11', '14'].each do |java_version|
let(:project_fixture) { 'java/maven/custom-tls' }
- let(:report_type) { :dependency_scanning }
let(:env) { { 'ADDITIONAL_CA_CERT_BUNDLE' => X509.self_signed.to_pem, 'DS_JAVA_VERSION' => java_version } }
specify do
diff --git a/spec/spotbugs_spec.rb b/spec/spotbugs_spec.rb
index 7706002..cd2cfc5 100644
--- a/spec/spotbugs_spec.rb
+++ b/spec/spotbugs_spec.rb
@@ -1,6 +1,6 @@
RSpec.describe 'spotbugs' do
let(:project_fixture) { 'java/maven/custom-tls' }
- let(:report_type) { :sast }
+ let(:scanner) { self.class.description }
specify { expect(subject).not_to be_nil }
specify { expect(subject['version']).to eql('3.0') }
diff --git a/spec/support/scanner_context.rb b/spec/support/scanner_context.rb
index 6a17835..3252d27 100644
--- a/spec/support/scanner_context.rb
+++ b/spec/support/scanner_context.rb
@@ -3,10 +3,11 @@ RSpec.shared_context 'a scanner' do
let(:docker) { Docker.new(pwd: Pathname.pwd.join("src/#{scanner}")) }
let(:docker_image) { "#{scanner}:latest" }
- let(:scanner) { self.class.description }
+ let(:scanner) { raise "`scanner` not specified. Choose: #{Pathname.pwd.glob('src/*').map(&:basename).join(', ')}" }
let(:project) { Project.new }
- let(:report_type) { raise 'report_type not specified' }
let(:env) { { } }
+ let(:report_types) { { 'gemnasium-maven' => :dependency_scanning, 'spotbugs' => :sast } }
+ let(:report_type) { report_types.fetch(scanner) }
around :example do |example|
project.mount(dir: fixture_file(project_fixture))