From dc612620ab4b9704519e37aa168c5c2d9c083bd1 Mon Sep 17 00:00:00 2001 From: mo Date: Sat, 10 Nov 2018 19:39:33 -0700 Subject: fix off by one on retry logic. --- lib/net/hippie/client.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/net/hippie/client.rb') diff --git a/lib/net/hippie/client.rb b/lib/net/hippie/client.rb index 0c94e4a..edd31ba 100644 --- a/lib/net/hippie/client.rb +++ b/lib/net/hippie/client.rb @@ -71,11 +71,11 @@ module Net # attempt 7 -> delay 64 second # attempt 8 -> delay 128 second def with_retry(retries: 3) - retries = 3 if retries <= 0 + retries = 0 if retries.nil? || retries.negative? 0.upto(retries) do |n| return yield self rescue *::Net::Hippie::CONNECTION_ERRORS => error - raise error if n >= retries + raise error if n == retries delay = (2**n) + rand(0.5) # delay + jitter warn("`#{error.message}` Retry: #{n + 1}/#{retries} Delay: #{delay}s") -- cgit v1.2.3