From 321a5d11a4b03451edfbb3745c7fd5bdb442b349 Mon Sep 17 00:00:00 2001 From: azohoori Date: Fri, 1 Feb 2019 13:49:42 -0700 Subject: adding open timeout attribute --- lib/net/hippie/client.rb | 2 ++ test/net/client_test.rb | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/lib/net/hippie/client.rb b/lib/net/hippie/client.rb index e554562..2343de7 100644 --- a/lib/net/hippie/client.rb +++ b/lib/net/hippie/client.rb @@ -12,6 +12,7 @@ module Net attr_accessor :mapper attr_accessor :read_timeout + attr_accessor :open_timeout attr_accessor :logger def initialize( @@ -99,6 +100,7 @@ module Net def http_for(uri) http = Net::HTTP.new(uri.host, uri.port) http.read_timeout = read_timeout + http.open_timeout = open_timeout if open_timeout http.use_ssl = uri.scheme == 'https' http.verify_mode = verify_mode http.set_debug_output(logger) diff --git a/test/net/client_test.rb b/test/net/client_test.rb index e20dffb..53f9b1f 100644 --- a/test/net/client_test.rb +++ b/test/net/client_test.rb @@ -229,4 +229,10 @@ class ClientTest < Minitest::Test end assert(@called) end + + def test_open_timeout_setting + assert_equal subject.open_timeout, nil + @subject.open_timeout = 10 + assert_equal subject.open_timeout, 10 + end end -- cgit v1.2.3 From b214fb81da6493c709249244983e92fae5d90acf Mon Sep 17 00:00:00 2001 From: azohoori Date: Fri, 1 Feb 2019 13:51:40 -0700 Subject: bumps up the gem version --- lib/net/hippie/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/hippie/version.rb b/lib/net/hippie/version.rb index 3c78850..0146f5c 100644 --- a/lib/net/hippie/version.rb +++ b/lib/net/hippie/version.rb @@ -2,6 +2,6 @@ module Net module Hippie - VERSION = '0.2.1' + VERSION = '0.2.2' end end -- cgit v1.2.3 From 51b686b39ff2056092b786501e5b9de3dea53e9e Mon Sep 17 00:00:00 2001 From: azohoori Date: Fri, 1 Feb 2019 14:23:47 -0700 Subject: compacting definition of attr_accessors --- lib/net/hippie/client.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/net/hippie/client.rb b/lib/net/hippie/client.rb index 2343de7..a23891c 100644 --- a/lib/net/hippie/client.rb +++ b/lib/net/hippie/client.rb @@ -10,10 +10,7 @@ module Net 'User-Agent' => "net/hippie #{Net::Hippie::VERSION}" }.freeze - attr_accessor :mapper - attr_accessor :read_timeout - attr_accessor :open_timeout - attr_accessor :logger + attr_accessor :mapper, :read_timeout, :open_timeout, :logger def initialize( certificate: nil, -- cgit v1.2.3