summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormo <mo@mokhan.ca>2018-05-07 15:31:53 -0600
committermo <mo@mokhan.ca>2018-05-07 15:32:07 -0600
commit84dc2be02ec86ebda02a6120bcc31e63048bc606 (patch)
tree5f5f10c7646112a38e3132a4ca5be836ffc7282a
parent6bb6fdb072c576a4d80e0e1869049ea122738695 (diff)
attempt to normalize uri.v0.1.3
-rw-r--r--lib/net/hippie/client.rb5
-rw-r--r--lib/net/hippie/version.rb2
-rw-r--r--test/net/client_test.rb8
3 files changed, 14 insertions, 1 deletions
diff --git a/lib/net/hippie/client.rb b/lib/net/hippie/client.rb
index 43ff407..d85096e 100644
--- a/lib/net/hippie/client.rb
+++ b/lib/net/hippie/client.rb
@@ -60,6 +60,7 @@ module Net
attr_reader :mapper
def http_for(uri)
+ uri = normalize_uri(uri)
http = Net::HTTP.new(uri.host, uri.port)
http.read_timeout = 30
http.use_ssl = uri.is_a?(URI::HTTPS)
@@ -80,6 +81,10 @@ module Net
x.body = mapper.map_from(body) unless body.empty?
end
end
+
+ def normalize_uri(uri)
+ uri.is_a?(URI) ? uri : URI.parse(uri)
+ end
end
end
end
diff --git a/lib/net/hippie/version.rb b/lib/net/hippie/version.rb
index d6ad3fd..db4dbe5 100644
--- a/lib/net/hippie/version.rb
+++ b/lib/net/hippie/version.rb
@@ -1,5 +1,5 @@
module Net
module Hippie
- VERSION = "0.1.2"
+ VERSION = "0.1.3"
end
end
diff --git a/test/net/client_test.rb b/test/net/client_test.rb
index 508fb03..2eaca20 100644
--- a/test/net/client_test.rb
+++ b/test/net/client_test.rb
@@ -17,6 +17,14 @@ class Net::Hippie::ClientTest < Minitest::Test
end
end
+ def test_get_with_string_uri
+ VCR.use_cassette("get_breaches") do
+ response = subject.get('https://haveibeenpwned.com/api/breaches')
+ refute_nil response
+ assert_equal(283, JSON.parse(response.body).count)
+ end
+ end
+
def test_get_with_block_syntax
VCR.use_cassette("get_breaches") do
uri = URI.parse('https://haveibeenpwned.com/api/breaches')