summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormo <mo@mokhan.ca>2018-05-07 15:23:33 -0600
committermo <mo@mokhan.ca>2018-05-07 15:23:33 -0600
commit6bb6fdb072c576a4d80e0e1869049ea122738695 (patch)
treed2f6b92afbc206a5c84e5fe807cf7e25dc9ad1eb
parent54ab2db6336b1116927200d6afc25e2af35282c8 (diff)
do not accept default headers in ctor.v0.1.2
-rw-r--r--README.md15
-rw-r--r--lib/net/hippie/client.rb3
-rw-r--r--test/net/client_test.rb6
3 files changed, 15 insertions, 9 deletions
diff --git a/README.md b/README.md
index c6acf03..ecbad05 100644
--- a/README.md
+++ b/README.md
@@ -26,12 +26,21 @@ require 'net/hippie'
Net::Hippie.logger = Rails.logger
-client = Net::Hippie::Client.new(headers: {
+client = Net::Hippie::Client.new
+
+headers = {
'Accept' => 'application/vnd.haveibeenpwned.v2+json'
-})
+}
-response = client.get(URI.parse('https://haveibeenpwned.com/api/breaches'))
+uri = URI.parse('https://haveibeenpwned.com/api/breaches')
+response = client.get(uri, headers: headers)
+puts JSON.parse(response.body)
+```
+```ruby
+client = Net::Hippie::Client.new
+body = { user: { name: 'hippie' } }
+response = client.post(URI.parse('https://example.com'), body: body)
puts JSON.parse(response.body)
```
diff --git a/lib/net/hippie/client.rb b/lib/net/hippie/client.rb
index 0433c02..43ff407 100644
--- a/lib/net/hippie/client.rb
+++ b/lib/net/hippie/client.rb
@@ -8,14 +8,13 @@ module Net
}
def initialize(
- headers: {},
certificate: nil,
key: nil,
passphrase: nil,
mapper: JsonMapper.new
)
@certificate = certificate
- @default_headers = DEFAULT_HEADERS.merge(headers)
+ @default_headers = DEFAULT_HEADERS
@key = key
@mapper = mapper
end
diff --git a/test/net/client_test.rb b/test/net/client_test.rb
index d4dee32..508fb03 100644
--- a/test/net/client_test.rb
+++ b/test/net/client_test.rb
@@ -5,9 +5,7 @@ class Net::Hippie::ClientTest < Minitest::Test
def initialize(*args)
super
- @subject = Net::Hippie::Client.new(headers: {
- 'Accept' => 'application/vnd.haveibeenpwned.v2+json'
- })
+ @subject = Net::Hippie::Client.new
end
def test_get
@@ -31,7 +29,7 @@ class Net::Hippie::ClientTest < Minitest::Test
end
def test_get_with_headers
- headers = { 'User-Agent' => 'example/agent' }
+ headers = { 'Accept' => 'application/vnd.haveibeenpwned.v2+json' }
WebMock.stub_request(:get, 'https://haveibeenpwned.com/api/breaches')
.with(headers: headers)
.to_return(status: 201, body: {}.to_json)