From 3949feb22fdda9986dfb2fafd2b95b290f528cb3 Mon Sep 17 00:00:00 2001 From: mo khan Date: Sat, 27 Feb 2021 17:38:07 -0700 Subject: move checklist to header --- lib/jive/templates/pull_request_template.md | 30 ++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lib/jive/templates/pull_request_template.md b/lib/jive/templates/pull_request_template.md index cac4b66..14288ee 100644 --- a/lib/jive/templates/pull_request_template.md +++ b/lib/jive/templates/pull_request_template.md @@ -1,6 +1,15 @@ -# Pull Request Template +--- +title: "Pull Request Template" +checklist: +- [ ] Clear description explaining the relevancy of the contribution. +- [ ] Unit, integration, and system tests. +- [ ] Regression and bugs are covered with tests. +- [ ] [Performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html) +- [ ] [Secure coding guidelines](https://docs.gitlab.com/ee/development/secure_coding_guidelines.html) +- [ ] Documentation Updated +--- -## Why is this needed? +# Why is this needed? ## What does this do? @@ -16,11 +25,11 @@ Fixes # (issue) Before: -![before]() +![Before][before] After: -![after]() +![After][after] ## Type of change @@ -38,14 +47,5 @@ After: - [ ] Step 1 - [ ] Step 2 -## Checklist - -- [ ] Clear description explaining the relevancy of the contribution. -- [ ] Unit, integration, and system tests. -- [ ] Regression and bugs are covered with tests. -- [ ] [Performance guidelines][performance] -- [ ] [Secure coding guidelines][secure] -- [ ] Documentation Updated - -[performance]: https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html -[secure]: https://docs.gitlab.com/ee/development/secure_coding_guidelines.html +[after]: https://user-images.githubusercontent.com/x/y.png +[before]: https://user-images.githubusercontent.com/x/y.png -- cgit v1.2.3