From 3ada0a4e55b56002a2492cf893034f074347a923 Mon Sep 17 00:00:00 2001
From: mo khan <mo.khan@gmail.com>
Date: Sat, 21 Nov 2020 15:16:01 -0700
Subject: feat: return 404 status code oid cannot be deleted

---
 server-rack.rb | 8 ++++++--
 test.rb        | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/server-rack.rb b/server-rack.rb
index 2f22a4b..3d4642b 100644
--- a/server-rack.rb
+++ b/server-rack.rb
@@ -39,8 +39,12 @@ class DataStorageServer
 
   def destroy(path)
     oid = id_from(path)
-    @storage.delete(oid)
-    ['200', {}, []]
+    if @storage.key?(oid)
+      @storage.delete(oid)
+      ['200', {}, []]
+    else
+      ['404', {}, []]
+    end
   end
 
   def call(env)
diff --git a/test.rb b/test.rb
index 429fa80..656e7b0 100644
--- a/test.rb
+++ b/test.rb
@@ -51,7 +51,7 @@ class DataStorageServerTest < Minitest::Test
     assert_equal 404, last_response.status
   end
 
-  def xtest_delete_nonexistant_object
+  def test_delete_nonexistant_object
     delete "/data/foo/nooope"
     assert_equal 404, last_response.status
   end
-- 
cgit v1.2.3