From 4a090d42089ded8ce38be51d08776131a6dd2e05 Mon Sep 17 00:00:00 2001 From: mo khan Date: Wed, 14 May 2025 17:14:12 -0600 Subject: refactor: remove unnecessary params from ctor --- pkg/oidc/oidc.go | 4 ++-- pkg/oidc/oidc_test.go | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) (limited to 'pkg') diff --git a/pkg/oidc/oidc.go b/pkg/oidc/oidc.go index 6ec1005..4704f63 100644 --- a/pkg/oidc/oidc.go +++ b/pkg/oidc/oidc.go @@ -13,7 +13,7 @@ type OpenID struct { OIDCConfig *oidc.Config } -func New(ctx context.Context, provider *oidc.Provider, clientID, clientSecret, callbackURL string) (*OpenID, error) { +func New(provider *oidc.Provider, clientID, clientSecret, callbackURL string) *OpenID { return &OpenID{ Provider: provider, Config: &oauth2.Config{ @@ -26,7 +26,7 @@ func New(ctx context.Context, provider *oidc.Provider, clientID, clientSecret, c OIDCConfig: &oidc.Config{ ClientID: clientID, }, - }, nil + } } func (o *OpenID) ValidateIDToken(ctx context.Context, rawIDToken RawToken) (*IDToken, error) { diff --git a/pkg/oidc/oidc_test.go b/pkg/oidc/oidc_test.go index bb040a2..a3dc7e4 100644 --- a/pkg/oidc/oidc_test.go +++ b/pkg/oidc/oidc_test.go @@ -1,11 +1,9 @@ package oidc import ( - "context" "testing" "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/require" ) func TestOpenID(t *testing.T) { @@ -13,15 +11,14 @@ func TestOpenID(t *testing.T) { defer srv.Close() t.Run("GET /.well-known/openid-configuration", func(t *testing.T) { - openID, err := New( - context.Background(), + openID := New( srv.Provider, srv.MockOIDC.ClientID, srv.MockOIDC.ClientSecret, "https://example.com/oauth/callback", ) - require.NoError(t, err) assert.Equal(t, srv.AuthorizationEndpoint(), openID.Provider.Endpoint().AuthURL) + assert.Equal(t, srv.TokenEndpoint(), openID.Provider.Endpoint().TokenURL) }) } -- cgit v1.2.3