From 2dd12b6a8109f05f508f382604f49744158d2080 Mon Sep 17 00:00:00 2001
From: mo khan <mo@mokhan.ca>
Date: Sat, 5 Jul 2025 11:32:15 -0600
Subject: test: invalid request variables in tests

---
 tests/authorization/cedar_authorizer_test.rs | 38 +++++++++++++---------------
 1 file changed, 17 insertions(+), 21 deletions(-)

(limited to 'tests/authorization')

diff --git a/tests/authorization/cedar_authorizer_test.rs b/tests/authorization/cedar_authorizer_test.rs
index ccf8a1f8..490a0107 100644
--- a/tests/authorization/cedar_authorizer_test.rs
+++ b/tests/authorization/cedar_authorizer_test.rs
@@ -21,28 +21,28 @@ mod tests {
 
     #[test]
     fn test_cedar_authorizer_denies_invalid_token() {
-        let request = build_request(|item: &mut HttpRequest| {
-            item.headers = build_headers(vec![(
-                "authorization".to_string(),
-                "Bearer invalid-token".to_string(),
-            )]);
-        });
-
-        assert!(!subject().authorize(request));
+        assert!(
+            !subject().authorize(build_request(|item: &mut HttpRequest| {
+                item.headers = build_headers(vec![(
+                    "authorization".to_string(),
+                    "Bearer invalid-token".to_string(),
+                )]);
+            }))
+        );
     }
 
     #[test]
     fn test_cedar_authorizer_denies_missing_header() {
-        let request = build_request(|item: &mut HttpRequest| {
-            item.headers = HashMap::new();
-        });
-
-        assert!(!subject().authorize(request));
+        assert!(
+            !subject().authorize(build_request(|item: &mut HttpRequest| {
+                item.headers = HashMap::new();
+            }))
+        );
     }
 
     #[test]
     fn test_cedar_authorizer_allows_static_assets() {
-        let request = build_request(|item: &mut HttpRequest| {
+        assert!(subject().authorize(build_request(|item: &mut HttpRequest| {
             let method = String::from("GET");
             let host = String::from("sparkle.staging.runway.gitlab.net");
             let path = "/public/style.css";
@@ -55,14 +55,12 @@ mod tests {
                 (String::from(":method"), method),
                 (String::from(":authority"), host),
             ]);
-        });
-
-        assert!(subject().authorize(request));
+        })));
     }
 
     #[test]
     fn test_cedar_authorizer_allows_js_assets() {
-        let request = build_request(|item: &mut HttpRequest| {
+        assert!(subject().authorize(build_request(|item: &mut HttpRequest| {
             let method = String::from("GET");
             let host = String::from("sparkle.staging.runway.gitlab.net");
             let path = "/app.js";
@@ -75,8 +73,6 @@ mod tests {
                 (String::from(":method"), method),
                 (String::from(":authority"), host),
             ]);
-        });
-
-        assert!(subject().authorize(request));
+        })));
     }
 }
-- 
cgit v1.2.3